@TomerStarkware reviewed 2 of 2 files at r2, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @orizi)

@orizi reviewed all commit messages.
Reviewable status: 0 of 2 files reviewed, 2 unresolved discussions (waiting on @TomerStarkware)

corelib/src/byte_array.cairo line 703 at r4 (raw file):

    fn at(self: @ByteSpan, index: usize) -> Option<u8> {
        let actual_index = index.checked_add(upcast(self.first_char_start_offset))?;
        let (word_index, index_in_word) = DivRem::div_rem(actual_index, BYTES_IN_BYTES31_NONZERO);

use bounded_int::div_rem and get index_in_word in [0,30] range.
you can use bounded_int::constrain later to decide if it is accessing the lower or upper word.

Code quote:

let (word_index, index_in_word) = DivRem::div_rem(actual_index, BYTES_IN_BYTES31_NONZERO);

corelib/src/byte_array.cairo line 713 at r4 (raw file):

                if word_index == self.data.len() && index_in_word < upcast(self.remainder_len) {
                    // index_in_word is from MSB, we need index from LSB.
                    let index_in_remainder = upcast(self.remainder_len) - 1 - index_in_word;

bounded_int::sub as well.

Code quote:

 let index_in_remainder = upcast(self.remainder_len) - 1 - index_in_word;

@TomerStarkware reviewed 3 of 3 files at r6, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @orizi)

@orizi reviewed 1 of 3 files at r6, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @giladchase)

corelib/src/byte_array.cairo line 917 at r6 (raw file):

    }

    pub fn bytespan_get_usize(self: @ByteSpan, index: usize) -> Option<u8> {

doc and improve name.

Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @orizi)

corelib/src/byte_array.cairo line 917 at r6 (raw file):

Done.

@orizi reviewed 3 of 3 files at r7, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

@orizi reviewed 4 of 4 files at r8, all commit messages.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @giladchase)

@orizi reviewed 2 of 3 files at r9, all commit messages.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @TomerStarkware)

corelib/src/byte_array.cairo line 1014 at r9 (raw file):

    // For byte_at: div_rem of (usize + BoundedInt<0,30>) by 31
    const USIZE_PLUS_30_DIV_31: felt252 = 0x8421085; // (usize::MAX + 30) / 31 = 138547333

should work.

Suggestion:

((Bounded::<usize>::MAX + 30) / 31).into();

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @orizi and @TomerStarkware)

corelib/src/byte_array.cairo line 1014 at r9 (raw file):

Messes up semantic:

thread '<unnamed>' panicked at crates/cairo-lang-semantic/src/items/constant.rs:839:19:
Variant extract failed: `Extern(ExternFunctionId(f830))` is not of variant `GenericFunctionId::Impl`

When debugging it i switched it the +30 to -30 and it passed semantic (but failed in the logic of course), meaning probably semantic is having problems deciding what type to evaluate this to (maybe it tries to evaluate the type after the addition before taking the Div into account?).
Maybe this is a bug in semantic.

@orizi reviewed all commit messages.
Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @giladchase and @TomerStarkware)

corelib/src/byte_array.cairo line 1014 at r9 (raw file):

lets go with `(Bounded::::MAX / 31 + 1).into(); instead.

Reviewable status: 4 of 5 files reviewed, 1 unresolved discussion (waiting on @orizi and @TomerStarkware)

corelib/src/byte_array.cairo line 1014 at r9 (raw file):

Nice, done.

@orizi reviewed 1 of 1 files at r12, all commit messages.
Reviewable status: 4 of 5 files reviewed, all discussions resolved (waiting on @TomerStarkware)

@orizi reviewed 1 of 1 files at r11.
Reviewable status: complete! all files reviewed, all discussions resolved (waiting on @giladchase)